Show Navigation
Conversation
Notices
-
@thelovebug@s.wefamlee.be I scrolled through the list of issues for #postActiv and found this about full acct URI mentioning for local IDs:
https://git.postactiv.com/postActiv/postActiv/issues/90
As a matter of fact, it works great in !GNUsocial (at least in the nightly branch, which is the one I probably recommend for everyone and will "soon" merge into master). It gets shortened automagically, so visually this is a bad example, but here I wrote the full .@anotheruser@social.umeahackerspace.se: @anotheruser
cc: @maiyannah
-
^- @thelovebug See above .]
-
@maiyannah Apparently that was a bug that only domains like the one @thelovebug@s.wefamlee.be has experience! The dealbreaker was the single 's' in the domain name and the regular expression which couldn't catch the full domain name because of that:
This: '!(?:^|\s+)@((?:\w+[\w\-\_\.]?)*(?:[\w\-\_\.]*\w+)@(?:\w+\-?\w+\.)*\w+(?:\w+\-\w+)*\.\w+)!'
changed to this: '/(?:^|\s+)@((?:\w+[\w\-\_\.]?)*(?:[\w\-\_\.]*\w+)@(?:(?!-)[A-Za-z0-9\-]{1,63}(?<!-)\.)+[A-Za-z]{2,10})/'
where the interesting part is the domain name regular expression. I have now, in !GNUsocial, put the fixes in the nightly branch and will also see if I can push to master.
-
@thelovebug Yeah, probably because I didn't mention you. The conversation is here: https://social.umeahackerspace.se/conversation/692325#notice-1055430
-
@takeshitakenji Anything that should go upstream?
-
@takeshitakenji I don't understand what would've caused an internal server error, especially only for local users. And I don't immediately see the practical change in the regex. You replaced the initial bit with a negative lookback for non-whitespace and then seemingly simplified the user-part (which is of course good and I think I'll copy).
@takeshitakenji I've even replied to you, so I obviously don't block: https://gs.kawa-kun.com/notice/1556135
-
Implemented it here: https://git.gnu.io/gnu/gnu-social/commit/95f991cff33d3e4ed1c36d9de0b7b541ab28eec0
-
@takeshitakenji No worries!